`devtools::test()` passes but `devtools::check()` does not

[njtierney]

OK.

So.

Thanks to @maelle for suggesting the following current solution, which is to remove all uses of mockery that refer to python parts.

Specifically, this commit: Address `check()` vs `test()` failure modes by njtierney · Pull Request #501 · greta-dev/greta · GitHub

it turns out that some of these mocked functions don't properly reset or something...which make greta think it doesn't have python...which causes 248 tests to fail because Python wasn't found.

I'm not sure why mockery is doing this? But it seems that it could be related to

mockery::stub is creating mocking functions that persist into other tests

Hmmm, can you unpack a bit more what you mean about defining a wrapper function that you can mock? Like, wrapping the function you want to mock up in a function, say I had something like so: is_windows <- function(){ .Platform$OS.type == "windows" } check_stuff <- function(){ if (is_windows()) stop("doesn't work on windows, sorry") }

At the moment I'm inclined to leave these tests out for the time being. Hopefully we can work out a way to resolve issues in mockery.

Thank you everyone for your help and suggestions!